Install regional browser locale data - #357
Open
tnsardesai wants to merge 1 commit into
Open
Conversation
tnsardesai
marked this pull request as ready for review
August 27, 2026 23:22
rgarcia
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
tzdataandlocalesin headful and headless browser imageswhy
Browser VMs need timezone data for process-level
TZhandling and generated locales forLANG/LC_ALL. Chrome also needs a matching locale resource pack or it falls back to a packaged locale.tests
Asia/Singapore/en-SGand verified the JavaScript timezone, Intl locale, and navigator languageNote
Low Risk
Docker image build-only changes with no application code paths; the en-GB locale alias is a pragmatic fallback that could differ slightly from native Chrome packs for those regions.
Overview
Headful and headless Chromium browser images now bake in timezone data and English regional locale support so VMs can honor process
TZandLANG/LC_ALLwithout falling back to minimal container defaults.Both Dockerfiles install
localesandtzdata, thenlocale-genforen_US,en_GB,en_CA,en_IE, anden_SGUTF-8. After Chrome for Testing is unpacked,en-GB.pakis copied toen-CA,en-IE, anden-SGlocale resource files so Chrome finds a matching pack for locales it does not ship separately.Reviewed by Cursor Bugbot for commit 1d00b0c. Bugbot is set up for automated code reviews on this repo. Configure here.